Skip to content

Add pyiceberg-core #31225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add pyiceberg-core #31225

wants to merge 9 commits into from
+98 −0

Conversation

@sumanth-manchala
Copy link
Contributor

@sumanth-manchala sumanth-manchala commented Oct 14, 2025 •
edited
Loading

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 14, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pyiceberg-core/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/pyiceberg-core/recipe.yaml:

  • ❌ The summary item is expected in the about section.
  • ❌ There are too few lines. There should be one empty line at the end of the file.
  • ❌ Non noarch packages should have python requirement without any version constraints.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18485289650. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 14, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyiceberg-core/recipe.yaml) and found it was in an excellent condition.

@sumanth-manchala
Copy link
Contributor Author

sumanth-manchala commented Oct 19, 2025

@conda-forge/help-python, ready for review

@sumanth-manchala
Copy link
Contributor Author

sumanth-manchala commented Nov 8, 2025

@conda-forge/help-python, please look into this

danielnachun
danielnachun requested changes Nov 24, 2025
View reviewed changes
recipes/pyiceberg-core/build.bat
Comment on lines +7 to +13
set "CMAKE_GENERATOR=NMake Makefiles"
maturin build -v --jobs 1 --release --strip --manylinux off --interpreter=%PYTHON% --no-default-features || exit 1

cd bindings/python

FOR /F "delims=" %%i IN ('dir /s /b target\wheels\*.whl') DO set pyiceberg_core_wheel=%%i
%PYTHON% -m pip install --ignore-installed --no-deps %pyiceberg_core_wheel% -vv || exit 1
Copy link
Contributor

@danielnachun danielnachun Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a comment above this to explain why it's necessary to directly call maturin here and manually install the wheels? I assume this is because the recipe fails if we just use pip install . -vv on Windows. This type of workaround is totally fine, but it would be good to document why it's needed for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielnachun danielnachun danielnachun requested changes

Assignees

No one assigned

Labels

python review-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sumanth-manchala @conda-forge-admin @danielnachun